Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Use black color for properties #119

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Use black color for properties #119

merged 1 commit into from
Apr 19, 2018

Conversation

worldbeater
Copy link
Contributor

@worldbeater worldbeater commented Apr 19, 2018

Now uses black color for properties also. This is how it was before (inconsistent):

image

This is how it is after (uses black like fields, variables, params, etc.):

image

This is what I've forgotten to implement here, sorry (:
Hope this is the final tweak, and we can keep calm and wait until linguist is released.

@@ -983,7 +983,7 @@ repository:
}
]
"8":
name: "entity.name.variable.property.cs"
name: "variable.other.cs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does variable.property.cs also render in black?

Copy link
Contributor Author

@worldbeater worldbeater Apr 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fallbacks to variable.cs which is light orange while variable.property color definition is missing. I've uploaded an example here which uses variable.property key.
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's go with this for now.

Once users get used to the new syntax we'll look at either introducing some new elements or going more down the path other languages have done.

@damieng damieng merged commit d4a054e into atom:master Apr 19, 2018
@ghost
Copy link

ghost commented May 14, 2018

@worldbeater, @damieng, is there an automatic way to update the cson from upstream https://github.com/dotnet/csharp-tmLanguage/blob/master/grammars/csharp.tmLanguage.cson and apply the patches? If no, then could we use https://github.com/dotnet/csharp-tmLanguage as a submodules and apply patches (checked in .patch files)? Then we can have a prepare script at root of this repo that applies the patch git apply patches/001-some-logical-name.patch.

@ghost
Copy link

ghost commented May 14, 2018

I am interested in changes from dotnet/csharp-tmLanguage#117 and previous two PRs :)

@damieng
Copy link
Contributor

damieng commented May 14, 2018

The plan was to try and get the changes applied upstream but I've had very little time to work on this since I left GitHub.

@ghost
Copy link

ghost commented May 14, 2018

The plan was to try and get the changes applied upstream

That would be great to have single source of truth. If it breaks other tm usages upstream, maybe there we can automate it using PCRE conversion script.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants