Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Add method call highlighting #109

Closed
wants to merge 1 commit into from
Closed

Add method call highlighting #109

wants to merge 1 commit into from

Conversation

worldbeater
Copy link
Contributor

@worldbeater worldbeater commented Jan 30, 2018

Added method call highlighting like in Java Atom plugin https://github.com/atom/language-java/blob/master/grammars/java.cson#L827

Now C#'s method chains look rather pretty! How it was before (ugly):

image

How it is now (pretty):

image

@worldbeater
Copy link
Contributor Author

@50Wliu @damieng need some help on failing tests 🤔

@damieng
Copy link
Contributor

damieng commented Jan 30, 2018

We actually have a plan to take the Microsoft-produced C# grammar and replace our own. I'll check in with them to find out where the tweak we needed is at.

@worldbeater
Copy link
Contributor Author

worldbeater commented Jan 31, 2018

Visual Studio Code C# grammar file is located in vscode official repository. It was generated using official C# syntax grammar. I've just tested that file in Atom - and it works fine, providing high-quality code highlighting. VsCode has MIT license applied, so there should be no issues with licenses.

This is how the code looks like in Atom with Microsoft's grammar:

image

So are there any other reasons for not implementing this now?
If it is needed, I can pull-request with the new grammar.

Thanks, @damieng!

@damieng
Copy link
Contributor

damieng commented Jan 31, 2018

There are issues with entity names we're trying to sort out to avoid regressing in a very obvious area with the variety of themes.

@worldbeater
Copy link
Contributor Author

Thank you very much for your work! Hope finally C# support in Github and in Atom will be as good as it is for languages like Java, Python or C++. It's so cool! 👍

Seems this pull request is no longer needed and can be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants