constant suggestion of "<?php" in mixed file

[racedaemon]

While editing php files that include html the plugin suggests "<?php" whenever i'm outside a php code block. This makes html editing really tedious.

[vinkla]

I've noticed this today as well. It never stops suggesting the <?php snippet abbreviation.

[jens1o]

That's a feature: https://github.com/felixfbecker/php-language-server/blob/35f33c8c91222b8409006cc68738e4000e33a4a3/src/CompletionProvider.php#L153-L164

[mikebronner]

I think the problem is that it makes this suggestion regardless of where the cursor is in the code. It would be great if it limited this suggestion only to the beginning of the file, as the code comments suggest it should. :)

[jens1o]

Hmm, that's worth a discussion. @felixfbecker Thoughts?

[felixfbecker]

Please see felixfbecker/php-language-server#372 (and upvote the linked LSP issue)

[sebj54]

While what you use is open-source, can't anyone fork it and add a configuration, leaving the actual behavior as default?
This is really annoying and I'm considering removing the whole atom-ide plugin just because of this bug... :(

[damieng]

It's not easy to change - it's part of the behavior of the underlying language server.

If there is a way to switch it off in ide-php we'll definitely consider a configuration switch here with no need to fork.

[sebj54]

Sure, but I meant by "fork" forking it and making a PR.
I don't know anything of the implementation, that's why I asked. But if it is hard to implement and we have to wait, it is really sad.

But what do we wait? This issue to be closed? microsoft/language-server-protocol#138

In that issue (felixfbecker/php-language-server#372), someone suggested to remove the following condition:

$node instanceof Node\Statement\InlineHtml

Maybe the switch you're talking about can be on that condition?

[felixfbecker]

Folks this is blocked by Microsoft VS Code / LSP. If you want to get a fix faster please express your need on the linked issue, I can't make it happen faster :)

[sebj54]

The fact is we know what we want on your module, but every time lose me more about VS Code, LSP or whatever is used. The only thing I can do is upvote the issue or eventually sign a petition 😄
Can you "up" the issue on LSP to make them understand their code is used on an Atom extension that is getting more popular everyday?

Thanks for your patience anyway :)

[damieng]

@felixfbecker Is there any way we can have a short term configuration option that just specifically disables <?php ?

The alternative I guess is I could just always filter this out client side?

[jens1o]

Personally, I think this would fit in Configuration Options(as described in the LSP), but these aren't implemented yet, afaik. Another simple operator is some kind of unmaintainable when it scales some day and it does not fit(Application Options shouldn't be passed via command line arguments). (but this is just my opinion)

[damieng]

@jens1o There are plenty of examples of extensions that people have added for additional functionality like this. Basically just need to come up with a new message and response or add a custom block to the initialization message.