Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Schema-up action, iteration N+1 #2127

Merged
merged 2 commits into from
May 7, 2019

Conversation

smashwilson
Copy link
Contributor

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

The command git push origin master is failing in our nightly action, because the local repository available from a schedule trigger has no master ref:

check run

ℹ  info      Fetching the latest GraphQL schema changes.
ℹ  info      Committing schema changes.
ℹ  info      Re-running relay compiler.
ℹ  info      Relay output:

Writing js
Unchanged: 62 files
ℹ  info      Generated relay files are unchanged.
✖  fatal     Error: Command failed: git push origin master 
error: src refspec master does not match any.
error: failed to push some refs to 'https://github.com/atom/github.git'


    at makeError (/node_modules/execa/index.js:174:9)
    at Promise.all.then.arr (/node_modules/execa/index.js:278:16)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:189:7)

I've changed it to default to a full refspec that should work as long as we have a repo:

git push origin HEAD:refs/heads/master

I've also bumped the schedule to try again tonight.

Screenshot/Gif

N/A

Alternate Designs

N/A

Benefits

Another iteration closer to the GitHub action introduced in #2108 working properly.

Possible Drawbacks

N/A

Applicable Issues

N/A

Metrics

N/A

Tests

image

Documentation

N/A

Release Notes

N/A

User Experience Research (Optional)

N/A

@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #2127 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2127      +/-   ##
==========================================
- Coverage   92.66%   92.65%   -0.01%     
==========================================
  Files         207      207              
  Lines       12045    12045              
  Branches     1764     1764              
==========================================
- Hits        11161    11160       -1     
- Misses        884      885       +1
Impacted Files Coverage Δ
lib/models/operation-states.js 89.58% <0%> (-2.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0b5fb4...c3e7942. Read the comment docs.

@smashwilson smashwilson merged commit b7de638 into master May 7, 2019
@winstliu winstliu deleted the aw/wait-you-dont-have-master-either-wtf branch May 7, 2019 16:23
@smashwilson smashwilson mentioned this pull request May 8, 2019
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant