This repository was archived by the owner on Dec 15, 2022. It is now read-only.
swap button colors to emphasize Comment more than `Resolve Conversa…
#2115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2115 +/- ##
=======================================
Coverage 92.65% 92.65%
=======================================
Files 207 207
Lines 12045 12045
Branches 1764 1764
=======================================
Hits 11160 11160
Misses 885 885
Continue to review full report at Codecov.
|
smashwilson
approved these changes
May 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept clicking "Resolve conversation" instead of "Comment" by accident, because the bright color of
btn-primarycalled to me. This PR swaps the colors of those two buttons, since "Comment" is more likely to be the button a user means to click.