This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Get author info tooltips working again #2104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2104 +/- ##
==========================================
+ Coverage 92.55% 92.58% +0.03%
==========================================
Files 207 207
Lines 12021 12021
Branches 1746 1746
==========================================
+ Hits 11126 11130 +4
+ Misses 895 891 -4
Continue to review full report at Codecov.
|
Otherwise, it turns out the `.splice()` calls modify the query directly, which can contaminate other specs in really weird ways 😱
kuychaco
approved these changes
Apr 29, 2019
smashwilson
added a commit
that referenced
this pull request
May 8, 2019
Get author info tooltips working again
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
Fixes #2094 by updating the GraphQL query and component props to reflect the renaming of
Organization#membersWithRoletoOrganization#members.Screenshot
N/A
Alternate Designs
UserMentionTooltipItem is one of the old-style tooltips. I could modernize it, but I opted for a surgical fix here.
Benefits
User mention tooltips will work again.
Possible Drawbacks
N/A
Applicable Issues
Fixes #2094
Metrics
N/A
Tests
I tested it out with the PR in the issue screenshot 😄
Documentation
N/A
Release Notes
User Experience Research (Optional)
N/A