Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Handle ghost users (deleted accounts) #2100

Merged
merged 31 commits into from
May 1, 2019
Merged

Handle ghost users (deleted accounts) #2100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
0e28f54
Add GHOST_USER to helpers file
kuychaco Apr 24, 2019
fb568cc
Account for Ghost user in Issueish model
kuychaco Apr 24, 2019
52b17e3
Account for Ghost user in PullRequestDetailView
kuychaco Apr 24, 2019
af8178f
Account for Ghost user in issueish tooltip
kuychaco Apr 24, 2019
12a10f3
Account for Ghost user in IssueishDetailView
kuychaco Apr 24, 2019
ca6a8a1
Account for Ghost users in ReviewsView
kuychaco Apr 24, 2019
df08570
Account for Ghost user in CommitCommentView
kuychaco Apr 24, 2019
91c1264
Account for Ghost user in IssueCommentView
kuychaco Apr 24, 2019
ef4091a
Actually import helper file...
kuychaco Apr 26, 2019
71ad2e1
Actually display login in IssueCommentView and fix tests
kuychaco Apr 29, 2019
585e4d6
Make author default in test graphql builders
kuychaco Apr 29, 2019
9d7c8d0
Use encodeURIComponent in report abuse link construction
kuychaco Apr 29, 2019
bd2967e
Use `author.url` field for constructing link to author on GitHub
kuychaco Apr 29, 2019
98db257
Add test for ghost user in ReviewsView
kuychaco Apr 29, 2019
fe4807a
Add ghost user test for IssueDetailView
kuychaco Apr 29, 2019
fbde935
Add ghost user test for PullRequestDetailView
kuychaco Apr 29, 2019
21e42c2
Explicitly indicate no author for ghost user test
kuychaco Apr 29, 2019
6f89c74
Add ghost user test for CommitCommentView
kuychaco Apr 29, 2019
dc7bb25
Make author field in PR test graphql builder nullable
kuychaco Apr 29, 2019
cd4ef4d
Focus test mysteriously failing on CI
kuychaco Apr 29, 2019
a8cde6f
Change prop types so that author is not required (ghost user)
kuychaco Apr 29, 2019
5a06437
Add IssueishTooltipContainer tests, including one for ghost user
kuychaco Apr 30, 2019
0d0cd52
Merge remote-tracking branch 'origin/master' into pr-2100/atom/ku-han…
smashwilson May 1, 2019
3266621
console.log stuff
smashwilson May 1, 2019
f60d186
Don't modify an object that is passed to components as props
smashwilson May 1, 2019
b68a9c8
Unlog
smashwilson May 1, 2019
9ed9377
PullRequest.author is nullable
smashwilson May 1, 2019
4b98402
Avoid re-assigning pullRequest.author prop in PullRequestDetailView
smashwilson May 1, 2019
ce11cd8
Revisit other places that are assigning GHOST_USER to a prop
smashwilson May 1, 2019
06cf1e9
Remove ye dot only
smashwilson May 1, 2019
5005ecb
Add `nullable: true` for builder fields where default value is null
kuychaco May 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/containers/__generated__/aggregatedReviewsContainerRefetchQuery.graphql.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions lib/containers/__generated__/commentDecorationsContainerQuery.graphql.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading