Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Allow :/ in remote URL #2086

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Allow :/ in remote URL #2086

merged 1 commit into from
Apr 23, 2019

Conversation

tjbenator
Copy link
Contributor

@tjbenator tjbenator commented Apr 19, 2019

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

Changed regex to allow for :/ in the remote URL:
git@github.com:/atom/github.git
ssh://git@github.com:/atom/github.git

This may fix issues some have had in #1010

Screenshot/Gif

N/A

Alternate Designs

N/A

Benefits

This will allow the following remote URLs and enable login to github:
git@github.com:/atom/github.git
ssh://git@github.com:/atom/github.git

Possible Drawbacks

I can't think of any

Applicable Issues

Metrics

N/A

Tests

I added the additional URLs to the models/remote.test.js. No new tests needed. I also verified the remote URL worked in git with a git pull

Documentation

N/A

Release Notes

Allows :/ in ssh/git URLs

User Experience Research (Optional)

Copy link

@annthurium annthurium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking a stab at this, @tjbenator !

looks good to me.

We have a team policy that community pull requests should be reviewed by 2 core team members, so I'll wait for a second approval before merging.

Copy link
Contributor

@smashwilson smashwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me. And thanks for adding tests 😄

@smashwilson smashwilson merged commit 51b13ae into atom:master Apr 23, 2019
@smashwilson smashwilson mentioned this pull request May 8, 2019
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants