Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Prefill some metadata for report abuse link in review comments #2074

Merged
merged 3 commits into from
Apr 17, 2019

Conversation

vanessayuenn
Copy link
Contributor

A piece of the feedback (#2056) we got from community & safety audit for the recently shipped review comments feature (#1995) suggests that the "report abuse" link in the review comment should include some metadata, so that important info can be prefilled.

@vanessayuenn vanessayuenn added the papercut Small-scope issues and bugs we can use to backfill our sprint plans label Apr 15, 2019
@vanessayuenn vanessayuenn requested a review from a team April 15, 2019 21:37
@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #2074 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2074      +/-   ##
==========================================
+ Coverage   92.55%   92.55%   +<.01%     
==========================================
  Files         207      207              
  Lines       12014    12016       +2     
  Branches     1746     1745       -1     
==========================================
+ Hits        11119    11121       +2     
  Misses        895      895
Impacted Files Coverage Δ
lib/views/reviews-view.js 82.71% <100%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8423c02...f858cc5. Read the comment docs.

@vanessayuenn vanessayuenn requested a review from annthurium April 16, 2019 17:01
Copy link

@annthurium annthurium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for addressing this!

It might be good to have a unit testing asserting that the query string params are part of the link, but ehh, I don't feel strongly enough about it to block merging.

@vanessayuenn vanessayuenn merged commit 9421207 into master Apr 17, 2019
@smashwilson smashwilson mentioned this pull request May 8, 2019
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
papercut Small-scope issues and bugs we can use to backfill our sprint plans
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants