This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Indicate that comment has been edited #2057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's probably a better way...
kuychaco
commented
Apr 10, 2019
Codecov Report
@@ Coverage Diff @@
## master #2057 +/- ##
==========================================
+ Coverage 92.54% 92.55% +<.01%
==========================================
Files 207 207
Lines 12010 12014 +4
Branches 1745 1746 +1
==========================================
+ Hits 11115 11119 +4
Misses 895 895
Continue to review full report at Codecov.
|
We're essentially doing the same thing twice so this is a bit DRYer, and allows us to avoid duplicating css.
annthurium
approved these changes
Apr 12, 2019
There was a problem hiding this comment.
looks great, @kuychaco ! Thanks for getting this out so quickly.
smashwilson
pushed a commit
that referenced
this pull request
May 8, 2019
Indicate that comment has been edited
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've shipped review comments we'll want to let folks know when a comment was edited. This was brought to our attention by the community and safety team, with respect to the fact that nasty comments can be edited.
While Dotcom shows the full edit history, we decided to simply indicate that the comment was edited and link the user to Dotcom where they can view more context if they would like to.
See #2056 for reference.
edited comment (modeled after dotcom):
edited review:
Alternate designs
I explored a visual treatment where we use a badge instead of bullet-separated text. It felt maybe a bit too visually overwhelming imo, in an already busy design.