Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Update to @atom/mocha-test-runner and mocha@6.0.2 #1991

Merged
merged 3 commits into from
Feb 27, 2019

Conversation

smashwilson
Copy link
Contributor

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

Change our test runner dependency from @smashwilson/atom-mocha-test-runner to @atom/mocha-test-runner. Update Mocha to match the version from the new runner.

Screenshot/Gif

hey look it still works

Alternate Designs

N/A

Benefits

Most immediately, it'll address some lagging dependencies and transitive dependencies, and fix #1965.

Possible Drawbacks

There's the possibility of breaking changes. This is a major-version bump for Mocha.

Applicable Issues

Fixes #1965.

Metrics

N/A

Tests

  • Verify that the graphical test runner works.
  • Verify that the headless test runner works.
  • Verify that our istanbul integration still works (by ensuring that the CodeCov results look correct).

Documentation

N/A

Release Notes

N/A

User Experience Research (Optional)

N/A

@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #1991 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1991      +/-   ##
==========================================
- Coverage   92.12%   92.12%   -0.01%     
==========================================
  Files         188      188              
  Lines       10809    10806       -3     
  Branches     1582     1581       -1     
==========================================
- Hits         9958     9955       -3     
  Misses        851      851
Impacted Files Coverage Δ
lib/git-shell-out-strategy.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ce6051...c2041e1. Read the comment docs.

@smashwilson smashwilson requested a review from a team February 27, 2019 17:43
@smashwilson
Copy link
Contributor Author

The build is green, aside from some wonkiness with the macOS beta build agent and the status check reporting.

@smashwilson smashwilson merged commit 9da49b7 into master Feb 27, 2019
@smashwilson smashwilson deleted the aw/update-test-runner branch February 27, 2019 19:09
@vanessayuenn vanessayuenn mentioned this pull request Mar 6, 2019
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants