Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Add tabs for issueish panel items #1684

Merged
merged 72 commits into from
Sep 25, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
3e3a9ae
npm install react-tabs
Sep 7, 2018
b96d246
Move some content into tabs
Sep 7, 2018
972e018
:fire: bullets
Sep 7, 2018
537c499
move timeline to conversation tab
Sep 7, 2018
11e9e7c
:sparkle: some css
Sep 8, 2018
8b4f50c
:shirt:
Sep 8, 2018
970d664
Merge branch 'master' of github.com:atom/github into tt-18-sept-tabs-…
Sep 10, 2018
eba451f
change "checks" to "build status"
Sep 10, 2018
7a820b0
change "conversation" to "overview"
Sep 10, 2018
4577610
add octicons and fix border
Sep 10, 2018
61ff2a1
add docked styles
Sep 10, 2018
e3e7853
add unit tests for tabs
Sep 10, 2018
8d6ff04
:shirt:
Sep 11, 2018
3041405
Files Changed => Commits
Sep 11, 2018
9d3a743
fetch commit data with relay
Sep 11, 2018
a1400c7
rendering some commits, woo
Sep 12, 2018
cb958d1
make it slightly less ugly
Sep 12, 2018
6dc93d0
more styling
Sep 12, 2018
8ccd2b2
fix borders and height
Sep 12, 2018
3b82e61
show the author avatar image
Sep 12, 2018
266dc2d
humanize timesince
Sep 12, 2018
ecda9e1
css variables are a thing.
Sep 12, 2018
271a54c
make button text say "hide" or "show"
Sep 12, 2018
bd86e50
clean up da props
Sep 12, 2018
b0bcc13
:shirt:
Sep 12, 2018
15b32b1
fix indentation, sigh
Sep 13, 2018
a5f7a8d
Merge branch 'master' of github.com:atom/github into tt-18-sept-tabs-tab
Sep 13, 2018
a77f17f
Move tabs styles
simurai Sep 13, 2018
808b598
Remove @separator-border-color
simurai Sep 13, 2018
00bd8fd
Expand tabs
simurai Sep 13, 2018
27da1a0
Style commits
simurai Sep 13, 2018
7d84de4
Use ellipsis icon for the show more button
simurai Sep 13, 2018
510094a
Fix breaking long words
simurai Sep 13, 2018
170138e
:shirt: againnnn
Sep 13, 2018
8e8e66d
don't show tabs on rendered issues
Sep 14, 2018
0ece22a
Use @text-color-highlight
simurai Sep 14, 2018
eb2b22a
Revert "Use ellipsis icon for the show more button"
simurai Sep 14, 2018
3c178c5
Add border to "show more" buttons
simurai Sep 14, 2018
91a855e
:shirt:
Sep 14, 2018
ecd0088
Merge branch 'master' of github.com:atom/github into tt-18-sept-tabs-…
Sep 14, 2018
5858b1f
add tests for PrCommitView
Sep 15, 2018
3ee1507
fix unit tests
Sep 17, 2018
2030b34
fix url prop
Sep 17, 2018
a808eaa
fix pr-statuses-view tests
Sep 17, 2018
fc9b8f1
wip - wtf am I doing wrong
Sep 19, 2018
8a6e8e6
it compiles, woo
Sep 19, 2018
1d58ecc
lowercase `pullRequest`
Sep 19, 2018
b7a5896
commits are actually loading
Sep 20, 2018
663c184
actually hook shit up
Sep 20, 2018
cc64a90
Merge branch 'master' of github.com:atom/github into tt-18-sept-tabs-…
Sep 20, 2018
4044a81
:fire: commented out code
Sep 20, 2018
4c2e1aa
styling fixes
Sep 20, 2018
4730252
add separate methods for rendering issue and pr bodies
Sep 20, 2018
e1e9efa
refactor `renderEmojiReactions` into a separate function
Sep 20, 2018
4f1ff4f
add comment about future improvements to header rendering
Sep 20, 2018
4a3650d
:shirt:
Sep 20, 2018
551a665
remove tab border when docked
Sep 20, 2018
235cfa2
fix IssueishDetailContaine tests
Sep 20, 2018
e4f575e
add some notes to checkout-pr test
Sep 20, 2018
c7e7033
Style "Load more" button in the Overview
simurai Sep 21, 2018
7613041
remove errant colon
Sep 21, 2018
6837b54
Merge branch 'tt-18-sept-tabs-tabs-tabs' of github.com:atom/github in…
Sep 21, 2018
c692fdb
change "link" to "button" in IssueishTimelineView tests
Sep 21, 2018
1542fe4
add tests for PrCommitView
Sep 21, 2018
0dcad21
add tests for loadMoreButton
Sep 21, 2018
9257976
Extract renderPrMetadata method for readability
kuychaco Sep 21, 2018
2a25458
:fire: .only
Sep 21, 2018
3c6a730
Merge branch 'tt-18-sept-tabs-tabs-tabs' of github.com:atom/github in…
Sep 22, 2018
4d2e7f1
:shirt:
Sep 22, 2018
8349385
extract fragment
Sep 24, 2018
3bd4100
fix tests
Sep 24, 2018
f88ab19
:shirt:
Sep 24, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
420 changes: 298 additions & 122 deletions lib/containers/__generated__/issueishDetailContainerQuery.graphql.js

Large diffs are not rendered by default.

8 changes: 7 additions & 1 deletion lib/containers/issueish-detail-container.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,16 @@ export default class IssueishDetailContainer extends React.Component {
$issueishNumber: Int!
$timelineCount: Int!
$timelineCursor: String
$commitCount: Int!
$commitCursor: String
) {
repository(owner: $repoOwner, name: $repoName) {
...issueishDetailController_repository @arguments(
issueishNumber: $issueishNumber,
timelineCount: $timelineCount,
timelineCursor: $timelineCursor,
issueishNumber: $issueishNumber,
commitCount: $commitCount,
commitCursor: $commitCursor,
)
}
}
Expand All @@ -120,6 +124,8 @@ export default class IssueishDetailContainer extends React.Component {
issueishNumber: this.props.issueishNumber,
timelineCount: 100,
timelineCursor: null,
commitCount: 100,
commitCursor: null,
};

return (
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 9 additions & 3 deletions lib/controllers/issueish-detail-controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -207,9 +207,11 @@ export default createFragmentContainer(BareIssueishDetailController, {
repository: graphql`
fragment issueishDetailController_repository on Repository
@argumentDefinitions(
issueishNumber: {type: "Int!"}
timelineCount: {type: "Int!"},
timelineCursor: {type: "String"},
issueishNumber: {type: "Int!"}
commitCount: {type: "Int!"},
commitCursor: {type: "String"},
) {
...issueishDetailView_repository
name
Expand All @@ -223,7 +225,9 @@ export default createFragmentContainer(BareIssueishDetailController, {
number
...issueishDetailView_issueish @arguments(
timelineCount: $timelineCount,
timelineCursor: $timelineCursor
timelineCursor: $timelineCursor,
commitCount: $commitCount,
commitCursor: $commitCursor,
)
}
... on PullRequest {
Expand All @@ -240,7 +244,9 @@ export default createFragmentContainer(BareIssueishDetailController, {
}
...issueishDetailView_issueish @arguments(
timelineCount: $timelineCount,
timelineCursor: $timelineCursor
timelineCursor: $timelineCursor,
commitCount: $commitCount,
commitCursor: $commitCursor,
)
}
}
Expand Down
Loading