Figure out if/how to handle new Review flow in Atom

[BinaryMuse]

[simurai]

Note: The following mostly focuses on resolving code reviews and less about creating them. The later can be improved if/when there is a way to open/create/merge a PR in Atom.

When opening the GitHub panel, all reviews show up in a list under the PR info:

• There is a filter to switch between All/Resolved/Unresolved. Does it need a search?
• On the right is a "progress" bar. This is to show how many reviews are already resolved and you get a sense of done vs total.
• Once a review is resolved, it fades out and gets a ✅ checkmark. It's a bit like a todo list that a PR author has to go through. I think this is nice because people love marking things as done.
• Unread reviews get a blue dot next to the avatar.

Then onto the reviews. Something to note: The reviews (items in the list) don't show the comments, but rather who made a review, when and the line of code where it was made. Maybe also the file name?

The reason is that these comments should only be read when shown in context (together with the code). Often the comments use things like this, referring to the line above.

Clicking on a review opens the file and shows the review comment(s) inline:

There is also a "Mark as resolved" button in case no changes are needed but you still want to mark it as ✅ done.

👉 continue with inline comments here #269

Some questions

• Can a resolved review be clicked? If the code doesn't exist, where should it show? Maybe in a separate pane with a diff view? Just a popup?
• If there are none or just a few reviews, it might feel like a waste having all this un-used space.
• How does the PR author get notified that there are new code reviews? Could be in the status-bar? Also, do you have to fetch to update the list? Or every time you open the panel?

[simurai]

How does the PR author get notified that there are new code reviews? Could be in the status-bar?

Something that came to mind: Not being notified is a feature too. 😆 There are already enough things constantly trying to get your attention, if the GitHub package would also start to show notifications, it would get even harder to focus on writing code and "getting into the zone". So ya, maybe just update the list once you open the panel is fine. Plus auto-updating if you keep the panel open.

[jvican]

@BinaryMuse @simurai Those suggestions look awesome. Is there any plan to add them to this package any time soon? If Atom gets GitHub code review right, it can be a huge selling point compared to other editor and IDE alternatives.

[annthurium]

closing in favor of #1706