Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Funky comment ordering within thread #1945

Closed
@kuychaco

Description

@kuychaco

Found a PR that has some funky comment ordering in Atom -- https://github.com/grokys/PullRequestSandbox/pull/23/files

Seems like an edge case, as comment ordering for https://github.com/kuychaco/test-repo/pull/5 appears to be fine.

pr__grokys_pullrequestsandbox_23_ testing_pr_comments_ __github_github_and_testing_pr_comments__by_grokys pull_request__23 _grokys_pullrequestsandbox_and_finders_course

Upon investigation, the "replyTo" field for the comments is not what I expected / have seen in other comment threads... usually the "replyTo" field always points to the top-level comment ("Comment 1 here." in this case). But we see that most of the comments in this thread actually refer to the comment directly before them.

testing_pr_comments__by_grokys_ pull_request__23 _grokys_pullrequestsandbox

Not sure when/why this happens... I looked the the pullRequestReview id for each of the comments and it seems that each comment belongs to a different review (as they are all distinct)... this is likely because all of the comments were made as stand-alone comments, and not part of an actual review. Though maybe I'm missing something here 🤔

pullRequestReview ID Comment body
MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzYzMjY4OTQ Baz
MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQzNjI0MzY Bar
MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQzNjEzNTU Foo
MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQzNTIwNzk Testing
MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzM4NTUyODY Comment 1 here
MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDQwMTc3MzU Why are there more comments here than on .com?
MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzM4NTUyODY Comment 1 here
MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NTcxNjM3OTU Inline HTML snippet
MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzM4NTUyODY Comment 1 here

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions