Git panel should only show current opened project status

@Samnan commented on Jul 19, 2018, 12:26 PM UTC:

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Git panel should always show the project git status, but it changes if a file from another project is opened in same window.

Steps to Reproduce

1. Open any project using git.
2. Open a single file from any other project/folder that also uses git
3. Git panel starts showing the modified changes from the project whose file is opened, instead of the project that is opened.

Expected behavior: Git panel should always show git status of current project, regardless of what file is opened.

Actual behavior: Git panel starts showing the modified changes from the project whose file is opened, instead of the project that is opened. This is very confusing and hopefully just a bug and not a feature.

Reproduces how often: Every time.

Versions

Atom: Latest as of this day.
OS: Mac High Sierra 10.13.5

You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.

Additional Information

Any additional information, configuration or data that might be necessary to reproduce the issue.

This issue was moved by rsese from atom/atom#17714.

[rsese]

Thanks for contributing! This is expected behavior as far as I know so tagging as feedback for now (if I'm wrong someone please let me know ✌️).

Git panel starts showing the modified changes from the project whose file is opened, instead of the project that is opened.

I guess the case where it makes the most sense is if you have multiple git projects open at once. But if you're opening a file outside of the currently open projects, I can see how that could be confusing.

[smashwilson]

Yeah, I would call this "expected, but maybe not optimal." If you have multiple projects open with git repositories, and you open a file outside of any of them, what should the current context of the git and GitHub tabs be? We follow the open pane item when possible because it's unambiguous, and because (theoretically) you're most likely to want to do git operations on the repository that contains the file you're actually editing.

I'm open to considering alternatives, but I'm not certain what they might be.

[nholden]

I've observed this behavior when opening files outside of a project that aren't in a Git repository, also. I bump into this because I have a file that I use for to-dos that doesn't live in Git repository, but I like to open it in the same Atom window as the project I'm working on (I do this via the scratch package).

It makes sense to me that if the file in the active pane lives in a Git repository, then we may want to use that repository in the Git and GitHub tabs. But when the file in the active pane doesn't live in a Git repository, what do you think about having the Git and GitHub tabs fallback to the repository for the open project?

[Samnan]

@nholden For me, Git tab should keep showing my project status considering if I have multiple projects open, I have a separate Atom window on my desktop for each project. So in my example, I have an older project and its new version on git, and whenever I intentionally/accidentally drag drop a file from old project to the window containing new project, the git tab starts showing the old project, which is very confusing.

So as far as my feedback goes, the git tab should always keep showing the current project status, not related to the file thats open.

[flamein]

Since recently the git tab doesn't seem to switch based on the open pane though, instead it has a dropdown box, so this particular bug report seems outdated

[ptousignant]

It does indeed. I found this looking for mention of that change in behavior though. I'd love a way to revert to automatically tracking the active project, even with the warts mentioned in this issue.

[smashwilson]

I'd love a way to revert to automatically tracking the active project, even with the warts mentioned in this issue.

Are you already following #2335 for the git context management tracking discussion? Also: you can temporarily use an older version of the github package by running apm install github@0.31.0-1 and adding "github" to the "Version Pinned Packages" core setting.

And yes, I believe this particular issue has become obsolete with the Identity and Context tile feature request work, although I'm not certain that the underlying concern is fully "resolved" per se. I'm going to close this issue so we can centralize git context tracking discussions in #2335.