This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Merged
Conversation
Upgraded to the commit libgit2/libgit2@9084712
Contributor
Author
|
Well this PR at the end seems to build fine 😓 If there's no opposition, tomorrow I'll merge it and release a new version of I know that this is not ideal (since we're not pinning |
This was referenced Jun 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the version of
libgit2used to the commit libgit2/libgit2@9084712This version contains the regression fix from libgit2/libgit2#4809 which prevented
libgit2to get upgraded and which we believe will make Atom builds less flaky.The reason why I haven't upgraded to latest
masterversion is because I cannot manage to buildlibgit2withnode-gypwith the changes in libgit2/libgit2#4919: when applying these changes I get the following error message fromnode-gyp:I've been able to work around the error by moving the static declaration in https://github.com/libgit2/libgit2/blob/master/src/hash/hash_generic.h#L24-L27 to L12, but I'm not exactly familiar with C so I have no idea if this is a good solution 😅 /cc @pks-t
Note: This is a big upgrade: It includes
libgit2changes from almost a year and 960 commits.