"Project Find" -> "Replace All" breaks encoding sometimes

[winstliu]

From @UdjinM6 on November 21, 2014 1:27

Example:

• clone https://github.com/bitcoin/bitcoin
• cmd + shift + f
• fill
  • 8333
  • 2222
  • *ru.ts
• hit "Replace All" and you'll get not only changes that you expected but also this (I did a cut from "git diff" to illustrate it better)

-        <translation>Промежуток от:</translation>
+        <translation>Промежуток ��т:</translation>

-        <translation>Не удалось записать информацию файла</translation>
+        <translation>Не удалось записать ин��ормацию файла</translation>

Atom 0.150.0
Mac OS 10.10

Copied from original issue: atom/atom#4268

[winstliu]

From @benogle on July 9, 2015 22:0

What encoding are you using?

[winstliu]

From @UdjinM6 on July 10, 2015 0:21

It's utf-8 I believe. And it not just *ru.ts, you can try *.ts to reproduce it for other languages. Also please note that bitcoin source changed since then so you will also need git checkout 0.9 to switch to the old branch in order to reproduce exactly the same case.

Reproduced again with Atom 1.0.2 on MacOS 10.10.3

[winstliu]

From @Uninen on October 19, 2016 21:44

I found this same bug while opening old files in ISO 8859-1, and trying to search & replace content in them. A file that has been opened in the project is ok, all other files end up mangled.

[winstliu]

From @exse2 on July 19, 2017 9:2

If you have .editorconfig file with these two lines:
[*]
charset = iso88591

Then do a "Replace All", not only it replaces all, but it also mangles German Umlauts (e.g. äöü). I suppose it does not convert the file back to this encoding after doing the replace internally. In short: The find-replace-in-all-files function does not give a crap about .editorconfig - find-replace on single file works though.

[winstliu]

From @gtsop on July 24, 2017 9:20

Same issue here. I have a project with files in ISO-8859-7 encoding. Find-replace-all ruins the greek letters.

edit: Ended up using good old sed... :(

find dirname/ -type f -exec sed -i 's/OLD_STR/NEW_STR/g' {} +

[GCSBOSS]

Would you have any priority on this issue? (consider this a +1)
I could try to do it myself, though I have very little experience with atom stuff. Would the problem be only in BufferSearch::replace?