"Find And Replace: Select All" hangs 1.3.2 and results in unexpected selections/cursors

[mnquintana]

From @WalterGR on December 25, 2015 4:20

Atom 1.3.2 on OS X 10.10.5.

I have a Clojure (.clj) file whose sections are marked with the text Section: I want to select all section headings, copy them, and paste them at the top of the file.

I didn't get very far, though. Selecting ^;; .*Section:.* seemed to hang Atom and I had to forcefully terminate it. This reproduced reliably.

While working towards a minimal test case, I searched for section: instead, and found that it's more likely that it's just taking a very long time, because the resulting selections are quite numerous. They're also rather... unexpected.

Notice that there are a ton of resulting selections - or perhaps cursors. I'm not entirely sure what I'm looking at, but it doesn't seem to be all instances of section: having been selected.

Let me know if you'd like the original file.

Copied from original issue: atom/atom#10179

[mnquintana]

From @jeancroy on December 25, 2015 23:3

There's 18 result found for section, so search is probably working well.
However there was work to change the data structure holding marker for search result. You possibly found a bug in that.

[WalterGR]

@mnquintana @jeancroy Yes, the search works fine, as does navigating between the results, etc. It's doing "Find And Replace: Select All" afterwards that causes the problem.

[WalterGR]

Here are more details.

• I can reproduce this 100%.
• It reproduces in safe mode.
• To restate, there are 2 issues. Let me know if I should open the second as a separate ticket.
• Find And Replace: Select All takes an extremely long time to finish.
• The results aren't as expected.
• The time it takes to finish the operation grows much faster than the size of the document.
• To Select All after searching for section: in my 52 kb document, an “Atom Helper” process would consume between 14 and 20 minutes of CPU time on an early 2015 MacBook Pro (2x 3.1 GHz, 16 GB).
• While I was seeking a minimal test case, the same operation in a document perhaps a third of the size would complete in IIRC less than a minute of wall time.
• I've attached the profiler output and 2 screenshots of the results when reproducing in the full 52 kb document. This time it took about 15 minutes of CPU time.

[atom-find-and-replace-ticket-627--find-and-replace-select-all-hangs-atom.cpuprofile.zip](https://github.com/atom/find-and-replace/files/72335/atom-find-and-replace-ticket-627--find-and-replace-select-all-hangs-atom.cpuprofile.zip)

[jeancroy]

Atom 1.3.2 or Atom 1.2.4 ? (Issue state 1.3 but screenshot of CPU profile is full of 1.2)

[WalterGR]

@jeancroy atom --version shows 1.3.2, as does the Atom menu in the app.

What you're seeing is that I installed 1.2.4 via homebrew-cask and Atom updated itself to 1.3.2.

In other words: ignore the directory name. :)

[warb12]

Well I am having trouble with simple search. 1.3.2 no results found for simple words I search for.

[adamreisnz]

I am also experiencing this since the latest Atom 1.3.2, on OS X 10.10.5. Some searches, I think particularly for finding files in the entire project, cause Atom to hang and I have to force close the window.

[WalterGR]

My specific issue no longer repros in 1.3.3.

@adambuczynski: Just to confirm, the problem you report in your comment, is it about using Find And Replace: Select All after doing a regex Find?

[adamreisnz]

No, I was doing a regular search. But I haven't experienced it anymore lately either.

[WalterGR]

@adambuczynski: Okay, thanks.

[WalterGR]

@mnquintana: Since I can no longer repro my specific issue in 1.3.3, you're welcome to close this ticket.

@warb12: Your issue is different than what this ticket is about. You may want to open a separate ticket about your specific issue.