Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Run script/bootstrap for pull requests originated from forks#19577

Merged
as-cii merged 1 commit intomasterfrom
as/fix-ci-for-forked-pull-requests
Jun 20, 2019
Merged

Run script/bootstrap for pull requests originated from forks#19577
as-cii merged 1 commit intomasterfrom
as/fix-ci-for-forked-pull-requests

Conversation

@as-cii
Copy link
Contributor

@as-cii as-cii commented Jun 20, 2019

Fixes #19543

The artifact caching task does not work on forks, so we need to bootstrap again on each parallel test suite for pull requests originated via a forked repository.

@as-cii as-cii requested a review from rafeca June 20, 2019 12:22
@as-cii as-cii merged commit 7e763a2 into master Jun 20, 2019
@as-cii as-cii deleted the as/fix-ci-for-forked-pull-requests branch June 20, 2019 14:55
@Aerijo
Copy link
Contributor

Aerijo commented Jun 20, 2019

@as-cii
Copy link
Contributor Author

as-cii commented Jun 20, 2019

Thanks for the heads-up, @Aerijo. Apologies for this! Unfortunately, it's kinda hard for me to test this behavior. Can you try pulling from as/upgrade-npm-for-macos-tests and see if it works? If so, I'll go ahead and merge it into master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MacOS CI broken

2 participants