This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Handle keyboardEvent.key being undefined on macOS #240
+46
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Linus Eriksson <Ben3eeE@users.noreply.github.com>
|
I wonder if we should make this change apply to all platforms? |
Ben3eeE
force-pushed
the
rs-handle-undefined-key
branch
from
07c3dc0
to
bb18734
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Linus Eriksson Ben3eeE@users.noreply.github.com
Requirements
Description of the Change
User has custom keymap where some keys are undefined:
https://discuss.atom.io/t/using-keyboard-layout-package/65697
This change makes it so on macOS, if this is the case, we use
keyboard-layoutto resolve the key.If the key is undefined, it probably makes sense to fallback to keyboard-layout (we currently get
undefinedin Atom).Alternate Designs
We could file an issue in Chrome and they could fix there.
Benefits
Resolve
undefinedkeystrokes in a more correct way instead of[modifier]-undefined. This is the best guess we have.Possible Drawbacks
User might have bound something to
alt-undefinedbut extremely unlikely.Applicable Issues
https://discuss.atom.io/t/using-keyboard-layout-package/65697