Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decaffeinate and update deps #464

Merged
merged 2 commits into from
Feb 6, 2020
Merged

decaffeinate and update deps #464

merged 2 commits into from
Feb 6, 2020

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Feb 4, 2020

Decaffeinate and update dependencies

fixes #463

I added eslint-config-standard for the eslint config. The code isn't very pretty from being decaffeinated but it works.

All dependencies are updated.

I updated the package-manager script as well from settings-view

Removed dependencies emissary and q

Tests all pass locally. It looks like travis doesn't have a valid PAT so api calls are rate limited.

@UziTech
Copy link
Member Author

UziTech commented Feb 4, 2020

I am planning on updating the other dependencies while I'm at it, I figured I would open this PR for discussion if there is anything specific I should use. (like eslint config)

@UziTech UziTech changed the title decaffeinate and update octokit decaffeinate and update deps Feb 4, 2020
@UziTech UziTech marked this pull request as ready for review February 4, 2020 16:17
@UziTech
Copy link
Member Author

UziTech commented Feb 4, 2020

@atom-community if you need a new maintainer for this repo (and/or other repos) I would love to help out.

@Cam
Copy link

Cam commented Feb 5, 2020

@UziTech If there is no movement here you should release your fork as a new package 👍

@UziTech
Copy link
Member Author

UziTech commented Feb 5, 2020

@dirk-thomas are you still maintaining this repo?

@dirk-thomas
Copy link
Contributor

are you still maintaining this repo?

No, I have moved away from Atom quite some time ago.

@dirk-thomas
Copy link
Contributor

If there is no movement here you should release your fork as a new package

I suggest to rather poke the current owner of the repo to consider giving permissions to a new maintainer rather than forking.

@UziTech
Copy link
Member Author

UziTech commented Feb 5, 2020

@dirk-thomas do you know who the current owner is?

@dirk-thomas
Copy link
Contributor

do you know who the current owner is?

Beside me @groupsky and @jerone are listed in the team associated to this repo.

@UziTech
Copy link
Member Author

UziTech commented Feb 5, 2020

@groupsky @jerone are either of you able to help with this?

@jerone
Copy link
Contributor

jerone commented Feb 5, 2020

@UziTech I have moved away from Atom for a long time. Ping me again over a few days if @groupsky doesn't respond. I can't add you to the @atom-community/sync-settings-maintainers team (one of the @atom-community/owners has to do that, I think), but I can add you to this repo.

@smashwilson
Copy link

@UziTech I just sent you an invite to join @atom-community/sync-settings-maintainers. Thanks for offering to help, and let me know if you need anything else! ❤️

@UziTech
Copy link
Member Author

UziTech commented Feb 6, 2020

@smashwilson Thanks. Is there any guidelines on maintaining this repo (e.g. use certain eslint config, etc.) and am I able to publish releases to atom.io?

@UziTech UziTech changed the title decaffeinate and update deps Merge pull request #464 from UziTech/octokit Feb 6, 2020
@UziTech UziTech merged commit 18d99f7 into atom-community:master Feb 6, 2020
@UziTech UziTech deleted the octokit branch February 6, 2020 16:31
@UziTech UziTech changed the title Merge pull request #464 from UziTech/octokit decaffeinate and update deps Feb 6, 2020
@UziTech
Copy link
Member Author

UziTech commented Feb 6, 2020

I use semantic-release for all of my packages. It has been a while since I used ol' apm publish. I figured it out but accidentally released it as v2.0.0 lol.

@smashwilson
Copy link

Is there any guidelines on maintaining this repo (e.g. use certain eslint config, etc.)

I don't know of any. But @simurai also literally just added me to this org last night, so I wouldn't consider myself an authority 😅

am I able to publish releases to atom.io?

Looks like it, so hooray!

@Arcanemagus
Copy link

am I able to publish releases to atom.io?

As far as I know anyone with write access to a repository can publish versions to atom.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Received a... few "...using the access_token query parameter is deprecated." emails today
6 participants