Fix config path with Atom 1.25 #403
Conversation
|
should probably use |
ykpythemind
force-pushed
the
fix_config_path
branch
from
6e8f654 to
0920cb0
Compare
ykpythemind
force-pushed
the
fix_config_path
branch
from
0920cb0 to
9dc0b2c
Compare
|
@UziTech Thank you. fixed. |
spec/sync-settings-spec.coffee
Outdated
| run (cb) -> | ||
| SyncSettings.backup cb | ||
| , -> | ||
| run (cb) => | ||
| SyncSettings.createClient().gists.get({id: @gistId}, cb) | ||
| , (err, res) -> | ||
| expect(res.files['init.coffee']).toBeDefined() | ||
| expect(res.files[path.basename(initPath)]).toBeDefined() |
There was a problem hiding this comment.
Please keep the changes for the init file in a separate PR since they are unrelated to the config path problem addressed in this PR.
There was a problem hiding this comment.
OK, fixed.
But in my environment, both init.coffee and init.js exists.
it "back up the user init.coffee file", ->
atom.config.set('sync-settings.syncInit', true)
run (cb) ->
SyncSettings.backup cb
this test backups init.js instead of init.coffee, so my test fails locally.
There was a problem hiding this comment.
The patch for the init files is still valid. Please create a separate PR for it though. Then they can get merged in whatever order is necessary to keep CI passing.
There was a problem hiding this comment.
OK, i will create.
ykpythemind
force-pushed
the
fix_config_path
branch
from
9dc0b2c to
d805893
Compare
|
opened #405 |
dirk-thomas
changed the title
when Atom beta 1.25.0beta0,
atom.config.configDirPathseems undefined.resolve #401