Skip to content

#181414724 (feature): Approvals Table #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

#181414724 (feature): Approvals Table #16

wants to merge 1 commit into from

Conversation

ste3ve3
Copy link
Collaborator

@ste3ve3 ste3ve3 commented May 25, 2022

What does this PR do?

Approve or reject user requests

Description of Task to be completed?

  • Design the UI
  • Use axios to call and fetch data from the api
  • Show an approving or rejecting toast notification once a request is approved or rejected
  • Redirecting the user back to the request tables

To test the changes manually:

  • clone repo on your local machine
  • switch to ch-approvals-table-181414724 branch
  • start the application with yarn dev command
  • on your browser go to http://localhost:8080/tripApproval
  • Try to accept or reject a trip request

Any background context you want to provide?

N/A

Useful links

N/A

What are the relevant pivotal tracker stories?

https://www.pivotaltracker.com/n/projects/2556266/stories/181414724

Screenshots (if appropriate)

N/A

Questions:

N/A

@vercel
Copy link

vercel bot commented May 25, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
code-ninjas-fe ✅ Ready (Inspect) Visit Preview Jun 18, 2022 at 0:45AM (UTC)

@niyojuste niyojuste added the needs rebase Task needs to get rebased label May 27, 2022
@ste3ve3 ste3ve3 force-pushed the ch-approvals-table-181414724 branch from 176cf3d to a139c16 Compare May 29, 2022 14:31
@ste3ve3 ste3ve3 added work in progress Work is still In Progress but quick review can be given and removed needs rebase Task needs to get rebased labels May 29, 2022
@ste3ve3 ste3ve3 force-pushed the ch-approvals-table-181414724 branch from a139c16 to 1afd169 Compare May 30, 2022 16:42
@ste3ve3 ste3ve3 force-pushed the ch-approvals-table-181414724 branch from 1afd169 to c12e801 Compare June 1, 2022 15:23
@ericus123 ericus123 added the needs rebase Task needs to get rebased label Jun 2, 2022
@Procech20 Procech20 force-pushed the ch-approvals-table-181414724 branch from c12e801 to 740ee81 Compare June 17, 2022 16:30
Procech20
Procech20 previously approved these changes Jun 17, 2022
View reviewed changes
@Procech20 Procech20 force-pushed the ch-approvals-table-181414724 branch from 740ee81 to 52989f8 Compare June 18, 2022 10:13
@ste3ve3 @Procech20
feat(approvals-table):Create manager approvals table
14bde4d 
- manager can view assigned trips
- manager can approve/reject trips
- components tested

[Delivers #181414724]
@Procech20 Procech20 force-pushed the ch-approvals-table-181414724 branch from 52989f8 to 14bde4d Compare June 18, 2022 12:43
@Procech20 Procech20 added enhancement New feature or request Ready for review and removed work in progress Work is still In Progress but quick review can be given needs rebase Task needs to get rebased labels Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Procech20 Procech20 Procech20 left review comments

@Robertishimwe Robertishimwe Awaiting requested review from Robertishimwe

@itisWasp itisWasp Awaiting requested review from itisWasp

@niyojuste niyojuste Awaiting requested review from niyojuste

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ste3ve3 @Procech20 @niyojuste @ericus123