Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to babel beta 56 #687

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Upgrade to babel beta 56 #687

merged 1 commit into from
Aug 7, 2018

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Aug 5, 2018

Babel runtime was split with @babel/runtime and @babel/runtime-corejs2
pacakges which allows to omit large core-js pacakge in many cases. Babel
runtime with only helpers became a default so users could include
necessary polyfills by themselves.

Babel runtime was split with @babel/runtime and @babel/runtime-corejs2
pacakges which allows to omit large core-js pacakge in many cases. Babel
runtime with only helpers became a default so users could include
necessary polyfills by themselves.
@alexreardon
Copy link
Collaborator

alexreardon commented Aug 5, 2018 via email

@TrySound
Copy link
Contributor Author

TrySound commented Aug 5, 2018

Currently I left as it is. Babel adds core-js Object.assign and Object.keys polyfills + helper versions with polyfills for es3. So bundle size is mostly increased unnecessary.

@TrySound
Copy link
Contributor Author

TrySound commented Aug 5, 2018

Here's the diff after removing core-js

 {
   "dist/react-beautiful-dnd.js": {
-    "bundled": 351336,
-    "minified": 131838,
-    "gzipped": 37030
+    "bundled": 346633,
+    "minified": 126400,
+    "gzipped": 35020
   },
   "dist/react-beautiful-dnd.min.js": {
-    "bundled": 311485,
-    "minified": 114193,
-    "gzipped": 31352
+    "bundled": 305938,
+    "minified": 108748,
+    "gzipped": 29298
   },
   "dist/react-beautiful-dnd.esm.js": {
-    "bundled": 180986,
-    "minified": 93116,
-    "gzipped": 23145,
+    "bundled": 180804,
+    "minified": 92948,
+    "gzipped": 23104,
     "treeshaked": {
       "rollup": {
-        "code": 68441,
-        "import_statements": 700
+        "code": 68400,
+        "import_statements": 566
       },
       "webpack": {
-        "code": 70717
+        "code": 70575
       }
     }
   }

@alexreardon
Copy link
Collaborator

Do you think it worth dropping core-js? Given it is only a small saving I think we could keep it for now. Thoughts?

@TrySound
Copy link
Contributor Author

TrySound commented Aug 5, 2018

Sure, it's not too much.

@alexreardon alexreardon merged commit 19b7ebf into atlassian:master Aug 7, 2018
@TrySound TrySound deleted the babel-56 branch August 7, 2018 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants