Tech debt: improve get node info to work both on server and DC #708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opopovss
requested review from
OlehStefanyshyn,
SergeyMoroz0703,
astashys and
ometelytsia
as code owners
ometelytsia
approved these changes
Nov 2, 2021
app/selenium_ui/jira/pages/pages.py
Outdated
| text = self.__get_footer_text() | ||
| return text.split('#')[0].replace('(v', '') | ||
|
|
||
| # def get_node_id(self): |
app/selenium_ui/jira/pages/pages.py
Outdated
| elif len(text_split) == 3: | ||
| return text_split[2].replace(')', '') | ||
| else: | ||
| return f"Warning: failed to get the node id from {text}" |
Collaborator
There was a problem hiding this comment.
- Looks like there is extra space after the colon.
- Let's change text to f"Warning: failed to get the node information from '{text}'." - this way we could easily catch a case when text is an empty string.
| elif len(text_split) == 3: | ||
| return text_split[2].replace(')', '') | ||
| else: | ||
| return f"Warning: failed to get the node id from {text}" |
Collaborator
There was a problem hiding this comment.
"Let's change text to f"Warning: failed to get the node information from '{text}'." - this way we could easily catch a case when text is an empty string."
Probably, you should change it here too
OlehStefanyshyn
approved these changes
Nov 2, 2021
…ork_both_on_server_and_DC
…n_server_and_DC' of github.com:atlassian/dc-app-performance-toolkit into dca_1351_Tech_debt_improve_get_node_info_to_work_both_on_server_and_DC
opopovss
deleted the
dca_1351_Tech_debt_improve_get_node_info_to_work_both_on_server_and_DC
branch
AbhinavPlugins
pushed a commit
to AbhinavPlugins/dc-app-performance-toolkit
that referenced
this pull request
Mar 1, 2025
…prove_get_node_info_to_work_both_on_server_and_DC Tech debt: improve get node info to work both on server and DC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.