Skip to content

DCA-1312: fix jsm prepare data script #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2021
Merged

DCA-1312: fix jsm prepare data script #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b270248
Fix: jsm_prepare_data.py script
opopovss Sep 23, 2021
3edac7e
Modified
opopovss Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/util/api/jsm_clients.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ def create_request(self, service_desk_id: int, request_type_id: int,

def get_request(self, issue_id_or_key: str, auth: tuple = None):
api_url = self.host + f"/rest/servicedeskapi/request/{issue_id_or_key}"
return self.get(api_url, f"Could not get customer request for id/key {issue_id_or_key}", auth=auth)
response = self.get(api_url, f"Could not get customer request for id/key {issue_id_or_key}", auth=auth)
return response.json()

def get_requests(self, start_at: int = 0, max_results: int = 100, auth: tuple = None, status: str = None):
"""
Expand Down
2 changes: 1 addition & 1 deletion app/util/data_preparation/jsm_prepare_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ def __get_custom_issues(jira_api, jsm_api, custom_jql):
)
for issue in issues:
expanded_issue = jsm_api.get_request(issue_id_or_key=issue['key'])
issue['service_desk_id'] = expanded_issue[0]['serviceDeskId']
issue['service_desk_id'] = expanded_issue['serviceDeskId']
if not issues:
print(f"There are no issues found using JQL {custom_jql}")
return issues
Expand Down