DCA-1016: Confluence prepare data script update #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ometelytsia
reviewed
Jul 30, 2021
|
|
||
| import urllib3 | ||
|
|
||
| from multiprocessing import cpu_count |
| @@ -1,14 +1,17 @@ | |||
| import random | |||
| import string | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
There are a bunch of missing imports related to the print_timing decorator.
| ENGLISH_GB = 'en_GB' | ||
|
|
||
|
|
||
| def print_timing(message, sep='-'): |
Collaborator
There was a problem hiding this comment.
This is a code duplication. jsm_prepare_data already has this. Need to extract this decorator to a common place, e.g. introduce new util file for prepare_data scripts.
| dataset[BLOGS] = __get_blogs(perf_user_api, 5000) | ||
|
|
||
| def __get_pages_blogs(func): | ||
| return func(perf_user_api, 5000) |
Collaborator
There was a problem hiding this comment.
With this approach, we break the possibility to modify the number of pages and blogs separately.
Also, the code is quite hard to understand.
Let's try something more simple and straight forward like:
pool = ThreadPool(processes=2)
async_pages = pool.apply_async(__get_pages, (perf_user_api, 5000))
async_blogs = pool.apply_async(__get_blogs, (perf_user_api, 5000))
async_pages.wait()
async_blogs.wait()
dataset[PAGES] = async_pages.get()
dataset[BLOGS] = async_blogs.get()
ometelytsia
approved these changes
Aug 2, 2021
| @print_timing('Creating dataset started') | ||
| def __create_data_set(rest_client, rpc_client): | ||
| dataset = dict() | ||
| dataset = dict([]) |
Collaborator
There was a problem hiding this comment.
Why this line was changed?
Contributor
Author
There was a problem hiding this comment.
probably it is just my mistake
mmizin
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.