bump client-go to v0.25.11 #66
Conversation
dtnyn
requested review from
awprice,
Jacobious52,
vincentportella,
hyang200 and
vcatlassian
dtnyn
force-pushed
the
bump/go-client-v1.25.11
branch
from
32f0da4
to
fdcb709
Compare
| @@ -181,8 +181,9 @@ type CycleNodeRequest struct { | |||
| metav1.TypeMeta `json:",inline"` | |||
| metav1.ObjectMeta `json:"metadata,omitempty"` | |||
|
|
|||
| Spec CycleNodeRequestSpec `json:"spec,omitempty"` | |||
| Status CycleNodeRequestStatus `json:"status,omitempty"` | |||
| ClusterName string `json:"clusterName,omitempty"` | |||
There was a problem hiding this comment.
Was the addition of ClusterName intended?
There was a problem hiding this comment.
Yeah apimachinery removed the field in v0.25.x https://github.com/kubernetes/apimachinery/blob/v0.25.11/pkg/apis/meta/v1/types.go#L258C34-L260
The field was removed since it wasn't needed by kubernetes
This field is not set anywhere right now and apiserver is going to ignore it if set in create or update request.
While we don't need it for any kubernetes functionality, we still need it since we piggybacked the meta clusterName field for cyclops notification components.
There was a problem hiding this comment.
Would this place the field inside the metadata field though?
There was a problem hiding this comment.
No it will be just under clustername sine we will (un)marshal it the same way where it's used by the notification https://github.com/atlassian-labs/cyclops/blob/master/pkg/notifications/slack/slack.go#L80-L91. If for convention, we can just create a new struct with the ObjectMeta promoted fields and clustername so we can put it under metadata
dtnyn
force-pushed
the
bump/go-client-v1.25.11
branch
from
fdcb709
to
d404a33
Compare
Bumping go-client version to v0.25.11