Skip to content

Make pagination work for fetching subpages of confluence page - #990

Merged
gonchik merged 1 commit into
atlassian-api:masterfrom
tmotyl:patch-1
Jun 18, 2022
Merged

Make pagination work for fetching subpages of confluence page#990
gonchik merged 1 commit into
atlassian-api:masterfrom
tmotyl:patch-1

Conversation

@tmotyl

@tmotyl tmotyl commented Jun 6, 2022

Copy link
Copy Markdown
Contributor

Fixes: #989

When a page has more than 25 subpages, the method get_child_id_list and similar are throwing an exception about wrong URL (missing domain).

This is caused by the fact that _get_paged method is setting absolute = True where it should be absolute = False
As according to documentation the _links.next page URL is relative (the domain is returned in _links.base field in the response.

@codecov-commenter

codecov-commenter commented Jun 18, 2022

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.03%. Comparing base (7176560) to head (93cc069).
Report is 350 commits behind head on master.

Files with missing lines Patch % Lines
atlassian/confluence.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #990   +/-   ##
=======================================
  Coverage   36.03%   36.03%           
=======================================
  Files          35       35           
  Lines        6726     6726           
  Branches     1040     1040           
=======================================
  Hits         2424     2424           
  Misses       4195     4195           
  Partials      107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken pagination in get_child_id_list & _get_paged

3 participants