Fix broken Bitbucket Cloud client #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing function call arguments, typos, SonarLint errors etc.
mandrean
force-pushed
the
fix/broken-bbcloud-client
branch
from
d8e56f5 to
5a5fd0d
Compare
|
I see only for 3 methods was renamed the naming variables like repository -> repository_slug |
|
Thank you for your suggestion. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bunch of issues/regressions introduced in the BB Cloud client with #609.
Note: It seems like a lot of refactoring was done without a proper Python IDE? Something like PyCharm + Mypy + Pylint + SonarLint would easily have alerted the developer of.
The PR also adds support for the alternative Bitbucket Cloud API URL, i.e.
https://api.bitbucket.org/2.0instead ofhttps://bitbucket.org/api/2.0.