Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jira] fix paginated projects retrieving #1343

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

ebaschiera
Copy link
Contributor

Fixes #1310

@Spacetown
Copy link
Contributor

This looks like a refactoring only. The logic is still the same.

@gonchik gonchik merged commit e0a7c6f into atlassian-api:master Mar 5, 2024
10 checks passed
@Spacetown
Copy link
Contributor

@gonchik Are you really sure that this fixes the issue? The loop is only restructured using variables but is still doing the same thing.

@gonchik
Copy link
Member

gonchik commented Mar 5, 2024

@Spacetown hm, it's automatically closed that issue.
I just merged iterator.

correct, fix must go wrapping startAt parameter.
https://developer.atlassian.com/cloud/jira/platform/rest/v3/api-group-projects/#api-rest-api-3-project-search-get

@Spacetown
Copy link
Contributor

Spacetown commented Mar 6, 2024

Yes, the iterative was only refactored. In the closed issue I linked a Branch where the same workaround as for the cloud is added. I raise a PR and you can check it.

Edit: Now I see it, also the project variable is modified now in the loop. In the original version this wasn't done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

endless loop when retrieving projects from the cloud
3 participants