Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bitbucket] Fixed Pull Requests Activities path #1326

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

roboqo
Copy link
Contributor

@roboqo roboqo commented Feb 3, 2024

Non existing API endpoint was used in the latest version, so this PR fixes that.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (26f450e) 34.35% compared to head (94d8475) 34.35%.

Files Patch % Lines
atlassian/bitbucket/__init__.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1326   +/-   ##
=======================================
  Coverage   34.35%   34.35%           
=======================================
  Files          45       45           
  Lines        8302     8302           
  Branches     1158     1158           
=======================================
  Hits         2852     2852           
  Misses       5336     5336           
  Partials      114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonchik gonchik merged commit 7c3dcee into atlassian-api:master Feb 3, 2024
10 checks passed
@gonchik gonchik changed the title Fixed Pull Requests Activities path [Bitbucket] Fixed Pull Requests Activities path Feb 10, 2024
@SkylerSalvato
Copy link
Contributor

@roboqo @gonchik

Hi, my team uses this with the Bitbucket Server REST API, and the endpoint actually still uses activities.
Would it be possible to implement this change specifically for Bitbucket Cloud, similar to the following?

https://github.com/roboqo/atlassian-python-api/blob/94d8475a445a5890258ff3049c149a8a7faa7ca4/atlassian/bitbucket/__init__.py#L1552-L1556

@SkylerSalvato
Copy link
Contributor

See my proposed change here: #1336

@taniajtaniaj
Copy link

Hi,
This change breaks our system. Our bitbucket supports "activities" but not "activity" ...

@SkylerSalvato
Copy link
Contributor

Hi, This change breaks our system. Our bitbucket supports "activities" but not "activity" ...

I created PR #1336 that fixes this, and it was merged, but the version has not been released yet. Until it is released you should be able to pin to the last version (atlassian-python-api==3.41.9).

@gonchik
Copy link
Member

gonchik commented Feb 26, 2024

@roboqo @taniajtaniaj I will publish a new release in a few hours

@taniajtaniaj
Copy link

thanks a lot! very much appreciated!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants