Skip to content

[Cloud] Prevent trailing / being added to requests to Commits if top (commit hash) is specified #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2024
Merged

[Cloud] Prevent trailing / being added to requests to Commits if top (commit hash) is specified #1320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion atlassian/bitbucket/cloud/repositories/commits.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ def each(self, top=None, q=None, sort=None):
params["sort"] = sort
if q is not None:
params["q"] = q
for commit in self._get_paged(top, trailing=True, params=params):
trailing=True
if top is not None:
trailing=False
for commit in self._get_paged(top, trailing=trailing, params=params):
yield self.__get_object(commit)

def get(self, commit_hash):
Expand Down