Jira: Rename tempo_4_timesheets_find_worklogs params (#1273) #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Rename the parameters of Jira.tempo_4_timesheets_find_worklogs as follows: - from -> date_from - "from" is a keyword, so it cannot be used as a parameter name - "date_from" is also used in Jira.tempo_timesheets_get_worklogs - See atlassian-api#1273 - to -> date_to - renamed for consistency with date_from
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1275 +/- ##
==========================================
- Coverage 34.47% 34.46% -0.02%
==========================================
Files 45 45
Lines 8173 8177 +4
Branches 1131 1133 +2
==========================================
Hits 2818 2818
- Misses 5241 5245 +4
Partials 114 114 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #1273, rename the parameters of
Jira.tempo_4_timesheets_find_worklogsas follows:from→date_fromfromis a keyword, so it cannot be used as a parameter namedate_fromis also used inJira.tempo_timesheets_get_worklogsto→date_todate_from