[Jira]: Migrate get all projects methods to use paginated endpoint for Jira Cloud. #1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marinone94
commented
Oct 25, 2023
marinone94
commented
- Migrate "get all projects" methods to use paginated endpoint for Jira Cloud.
- Update docs.
- Use the correct method in the archive project method.
…loud. Use correct method in archive project function.
|
Hi @marinone94 , Main idea, just make quite easy steps for understanding code by non-developers |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1270 +/- ##
==========================================
- Coverage 34.54% 34.48% -0.07%
==========================================
Files 45 45
Lines 8148 8172 +24
Branches 1124 1131 +7
==========================================
+ Hits 2815 2818 +3
- Misses 5219 5240 +21
Partials 114 114
☔ View full report in Codecov by Sentry. |
|
How about wrap other methods? |
|
What do you mean? |
|
@marinone94 i meant wrap other rest api requests |
grahamalama
added a commit
to mozilla/jira-bugzilla-integration
that referenced
this pull request
Dec 11, 2023
In v6.3.6, we bumped atlassian-python-api from 3.41.4. That bump included a [PR](atlassian-api/atlassian-python-api#1270) which changed the way library fetched projects. This somehow affected our project when we fetched visible projects and issue types in the heartbeat. We never fully determined the root cause, but the while loop in the linked PR was suspect. In this commit, we make further improvements to the code that's involved in the heartbeat to make it more efficent. Note that one of the tradeoffs we made for now was hardcoding the maximum number of projects that may be configured at 50. This is due to the way we fetch issue types by project. This is something that we can fix in the future, but is not a problem that we need to solve for now since we only have 26 project configured.
grahamalama
added a commit
to mozilla/jira-bugzilla-integration
that referenced
this pull request
Dec 11, 2023
In v6.3.6, we bumped atlassian-python-api from 3.41.4. That bump included a [PR](atlassian-api/atlassian-python-api#1270) which changed the way library fetched projects. This somehow affected our project when we fetched visible projects and issue types in the heartbeat. We never fully determined the root cause, but the while loop in the linked PR was suspect. In this commit, we make further improvements to the code that's involved in the heartbeat to make it more efficent. Note that one of the tradeoffs we made for now was hardcoding the maximum number of projects that may be configured at 50. This is due to the way we fetch issue types by project. This is something that we can fix in the future, but is not a problem that we need to solve for now since we only have 26 project configured.
grahamalama
added a commit
to mozilla/jira-bugzilla-integration
that referenced
this pull request
Dec 11, 2023
In v6.3.6, we bumped atlassian-python-api from 3.41.4. That bump included a [PR](atlassian-api/atlassian-python-api#1270) which changed the way library fetched projects. This somehow affected our project when we fetched visible projects and issue types in the heartbeat. We never fully determined the root cause, but the while loop in the linked PR was suspect. In this commit, we make further improvements to the code that's involved in the heartbeat to make it more efficent. Note that one of the tradeoffs we made for now was hardcoding the maximum number of projects that may be configured at 50. This is due to the way we fetch issue types by project. This is something that we can fix in the future, but is not a problem that we need to solve for now since we only have 26 project configured.
grahamalama
added a commit
to mozilla/jira-bugzilla-integration
that referenced
this pull request
Dec 11, 2023
In v6.3.6, we bumped atlassian-python-api from 3.41.4. That bump included a [PR](atlassian-api/atlassian-python-api#1270) which changed the way library fetched projects. This somehow affected our project when we fetched visible projects and issue types in the heartbeat. We never fully determined the root cause, but the while loop in the linked PR was suspect. In this commit, we make further improvements to the code that's involved in the heartbeat to make it more efficent. Note that one of the tradeoffs we made for now was hardcoding the maximum number of projects that may be configured at 50. This is due to the way we fetch issue types by project. This is something that we can fix in the future, but is not a problem that we need to solve for now since we only have 26 project configured.
grahamalama
added a commit
to mozilla/jira-bugzilla-integration
that referenced
this pull request
Dec 11, 2023
In v6.3.6, we bumped atlassian-python-api from 3.41.4. That bump included a [PR](atlassian-api/atlassian-python-api#1270) which changed the way library fetched projects. This somehow affected our project when we fetched visible projects and issue types in the heartbeat. We never fully determined the root cause, but the while loop in the linked PR was suspect. In this commit, we make further improvements to the code that's involved in the heartbeat to make it more efficent. Note that one of the tradeoffs we made for now was hardcoding the maximum number of projects that may be configured at 50. This is due to the way we fetch issue types by project. This is something that we can fix in the future, but is not a problem that we need to solve for now since we only have 26 project configured.
grahamalama
added a commit
to mozilla/jira-bugzilla-integration
that referenced
this pull request
Dec 11, 2023
In v6.3.6, we bumped atlassian-python-api from 3.41.4. That bump included a [PR](atlassian-api/atlassian-python-api#1270) which changed the way library fetched projects. This somehow affected our project when we fetched visible projects and issue types in the heartbeat. We never fully determined the root cause, but the while loop in the linked PR was suspect. In this commit, we make further improvements to the code that's involved in the heartbeat to make it more efficent. Note that one of the tradeoffs we made for now was hardcoding the maximum number of projects that may be configured at 50. This is due to the way we fetch issue types by project. This is something that we can fix in the future, but is not a problem that we need to solve for now since we only have 26 project configured.
grahamalama
added a commit
to mozilla/jira-bugzilla-integration
that referenced
this pull request
Dec 11, 2023
In v6.3.6, we bumped atlassian-python-api from 3.41.4. That bump included a [PR](atlassian-api/atlassian-python-api#1270) which changed the way library fetched projects. This somehow affected our project when we fetched visible projects and issue types in the heartbeat. We never fully determined the root cause, but the while loop in the linked PR was suspect. In this commit, we make further improvements to the code that's involved in the heartbeat to make it more efficent. Note that one of the tradeoffs we made for now was hardcoding the maximum number of projects that may be configured at 50. This is due to the way we fetch issue types by project. This is something that we can fix in the future, but is not a problem that we need to solve for now since we only have 26 project configured.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.