[ISSUE-1241] #1241, added propagation of advanced_mode flag
#1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flag for `put`, `post`, `patch`, and `delete` functions. Prior to this change, the `advanced_mode` flag was only propagated to the `request` method for `get` calls. The `advanced_mode` `requests.Response` object is very useful in having code gracefully handle rate limit 429 responses from the server since the response headers will include the necessary backoff information that the client should use before making another request.
Codecov ReportPatch and project coverage have no change.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1243 +/- ##
=======================================
Coverage 34.47% 34.47%
=======================================
Files 44 44
Lines 8105 8105
Branches 1118 1118
=======================================
Hits 2794 2794
Misses 5197 5197
Partials 114 114
☔ View full report in Codecov by Sentry. |
|
@2ps could you update a docs please? |
Apologies for missing this. Will address in a separate PR since this one has already been merged. |
My bad, it looks like this was already included in the docs for put, post, patch, and delete but just had not been wired in. At least from my review there were no docs to update. Please do point me in the right direction if I have overlooked something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1241
added propagation of the
advanced_modeflag forput,post,patch, anddeletefunctions. Prior to this change, theadvanced_modeflag was only propagated to therequestmethod forgetcalls. Theadvanced_moderequests.Responseobject is very useful in having code gracefully handle rate limit 429 responses from the server since the response headers will include the necessary backoff information that the client should use before making another request.