lists and dicts can be handled in raise_for_status #1234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve #1230.
I tried to straighten out the code a bit.
I am not sure why we checked if the key from .items() is a dict. That is not possible.
I guess in an earlier version we iterated over a presumed dict and named the variable k(for key) (But in the background it was a list). fc620ae
Then it was modified. But they then stopped iterating over the object but iterated over the items, which are apparently not always present. 4bb337a
I looks like some classic list/dict confusion but in the end I am not sure what possible responses are. Feedback would be appreciated.
I shoehorned a testcases in there to check for this error.
With regards to #1228 . The response I got with that error has the content-type: 'application/json;charset=UTF-8' which he specifically does not trigger for.