Skip to content

This will give you a fixed-width page. #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Conversation

zackn9ne
Copy link

This will give you a fixed-width page.

zackn9ne added 2 commits March 17, 2023 15:36
allows fixed-width for page create & update
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (cce5c3f) 34.08% compared to head (4e7a349) 34.06%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1135      +/-   ##
==========================================
- Coverage   34.08%   34.06%   -0.02%     
==========================================
  Files          40       40              
  Lines        7596     7600       +4     
  Branches     1053     1053              
==========================================
  Hits         2589     2589              
- Misses       4897     4901       +4     
  Partials      110      110              
Impacted Files Coverage Δ
atlassian/confluence.py 13.09% <0.00%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zackn9ne zackn9ne changed the title allow False full-width This will allow fix width page Mar 20, 2023
@zackn9ne zackn9ne changed the title This will allow fix width page this will give you a fixed-width page Mar 20, 2023
@zackn9ne zackn9ne changed the title this will give you a fixed-width page This will give you a fixed-width page Mar 20, 2023
@zackn9ne zackn9ne changed the title This will give you a fixed-width page This will give you a fixed-width page. Mar 20, 2023
@zackn9ne
Copy link
Author

At Confluence, for update-page method, if you already have a full-width page and you send full-width: False the logic does not work. You still end up with a full-width page.

This patch fixes that.

@gonchik gonchik merged commit 4e10bec into atlassian-api:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants