Skip to content

Alias get_organizations #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2023
Merged

Alias get_organizations #1134

merged 2 commits into from
Apr 9, 2023

Conversation

mmahacek
Copy link
Contributor

There's a spelling inconsistency of 'organisations'. This PR adds service_desk.get_organizations() as an alias of get_organisations() to maintain compatibility while allowing for correct spelling.

Add `service_desk.get_organizations()` as an alias of `get_organisations()`.
@gonchik
Copy link
Member

gonchik commented Mar 17, 2023

Hi!
Thanks for the highlighting that.
@mmahacek btw, did you check that code ?

@mmahacek
Copy link
Contributor Author

Added tests (which pass for me) to verify the same result.

Alternatively, could also do this to achieve the same result:

-    get_organizations = get_organisations
+    def get_organizations(self, service_desk_id=None, start=0, limit=50):
+        return self.get_organisations(service_desk_id=service_desk_id, start=start, limit=limit)

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (cce5c3f) 34.08% compared to head (cba89ce) 34.09%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1134   +/-   ##
=======================================
  Coverage   34.08%   34.09%           
=======================================
  Files          40       40           
  Lines        7596     7597    +1     
  Branches     1053     1053           
=======================================
+ Hits         2589     2590    +1     
  Misses       4897     4897           
  Partials      110      110           
Impacted Files Coverage Δ
atlassian/service_desk.py 38.92% <100.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gonchik gonchik merged commit 13ae342 into atlassian-api:master Apr 9, 2023
@gonchik
Copy link
Member

gonchik commented Apr 9, 2023

Hi @mmahacek ,
Thanks for the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants