Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Failing Tests: Correction to adanced_usage=True #1074

Merged
merged 3 commits into from
Nov 10, 2022

Conversation

martynbristow
Copy link
Contributor

return None instead of response

…ect thing for this example (pretty-print-usage)

Signed-off-by: Martyn Bristow <martyn.bristow@gmail.com>
…eturning raw response

Return None on 404. Preserve Existing Functionality

Signed-off-by: Martyn Bristow <martyn.bristow@gmail.com>
@martynbristow
Copy link
Contributor Author

@gonchik ... I've made a change to make the tests pass while preserving functionality

Be interested in your perspective

@codecov-commenter
Copy link

Codecov Report

Base: 36.09% // Head: 36.11% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (2b5b245) compared to base (a425402).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1074      +/-   ##
==========================================
+ Coverage   36.09%   36.11%   +0.01%     
==========================================
  Files          38       38              
  Lines        6970     6972       +2     
  Branches     1008     1008              
==========================================
+ Hits         2516     2518       +2     
- Misses       4346     4347       +1     
+ Partials      108      107       -1     
Impacted Files Coverage Δ
...tlassian/bitbucket/cloud/repositories/pipelines.py 64.03% <100.00%> (-1.15%) ⬇️
atlassian/rest_client.py 70.25% <100.00%> (+1.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gonchik
Copy link
Member

gonchik commented Nov 10, 2022

Hi @martynbristow
I do support the exact return.

Thanks for the PR

@gonchik gonchik merged commit 9a07d9e into atlassian-api:master Nov 10, 2022
@martynbristow
Copy link
Contributor Author

The build should go green now
Hope that's all good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants