Skip to content

Fix getting of cloud commit #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Spacetown
Copy link
Contributor

The function Commits.each uses the wrong URL https://api.bitbucket.org/2.0/repositories/{workspace}/{repo}/commits/{commit} in the yield expression. Here the Commits.get must be used with the commit hash as argument.

Closes #1071

@codecov-commenter
Copy link

Codecov Report

Base: 36.09% // Head: 36.09% // No change to project coverage 👍

Coverage data is based on head (465bc66) compared to base (96e0cd1).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1073   +/-   ##
=======================================
  Coverage   36.09%   36.09%           
=======================================
  Files          38       38           
  Lines        6970     6970           
  Branches     1008     1008           
=======================================
  Hits         2516     2516           
  Misses       4346     4346           
  Partials      108      108           
Impacted Files Coverage Δ
atlassian/bitbucket/cloud/repositories/commits.py 46.87% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gonchik
Copy link
Member

gonchik commented Nov 7, 2022

Interesting to look to 2 PR like that one #1072

@Spacetown
Copy link
Contributor Author

Sorry, I only saw the issue and there was no PR linked and no comment.

@Spacetown Spacetown closed this Nov 7, 2022
@Spacetown Spacetown deleted the fix_getting_of_cloud_commit branch March 5, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bitbucket] repository.commits.each() -> Expected type of data is [commit], got [None]
3 participants