Skip to content

[Jira] Fix the parameter of remove_user_from_group from username to account id #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions atlassian/jira.py
Original file line number Diff line number Diff line change
Expand Up @@ -772,18 +772,27 @@ def add_user_to_group(self, username, group_name):
data = {"name": username}
return self.post(url, params=params, data=data)

def remove_user_from_group(self, username, group_name):
def remove_user_from_group(self, username=None, group_name=None, account_id=None):
"""
Remove given user from a group

For Jira DC/Server platform
:param username: str
:param group_name: str
:return:

For Jira Cloud platform
:param account_id: str (username is no longer available for Jira Cloud platform)
:param group_name: str
:return:
"""
log.warning("Removing user from a group...")
url = self.resource_url("group/user")
params = {"groupname": group_name, "username": username}

url_domain = self.url
if "atlassian.net" in url_domain:
params = {"groupname": group_name, "accountId": account_id}
else:
params = {"groupname": group_name, "username": username}
return self.delete(url, params=params)

def get_users_with_browse_permission_to_a_project(
Expand Down
2 changes: 1 addition & 1 deletion docs/jira.rst
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ Manage groups
jira.add_user_to_group(username, group_name)

# Remove given user from a group
jira.remove_user_from_group(username, group_name)
jira.remove_user_from_group(username=None, group_name=None, account_id=None)

Manage projects
---------------
Expand Down