issue with raise_for_status()

[slmnsh]

Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/atlassian/rest_client.py", line 395, in raise_for_status
error_msg = "\n".join(j["errorMessages"] + [k + ": " + v for k, v in j["errors"].items()])
KeyError: 'errorMessages'

this happens when I try to add labels to any repo using bitbucket.set_repo_label() function

I think this commit is the reason of this issue because I'm regular user of this library and never faced anything like this
50b5c71

[gonchik]

Hi @salmannotkhan ,
noted. let me wrap KeyError: 'errorMessages'

[slmnsh]

Thanks for the quick response :)

[slmnsh]

This is the response from the server.
{'errors': [{'context': None, 'message': "Label name '0D930811-B3F7-4875-97BD-7DF252F907CA' cannot contain capital letters.", 'exceptionName': 'com.atlassian.bitbucket.label.InvalidLabelException'}]}
You can update script accordingly

[flichtenheld]

Note: I provided a fix for Bitbucket Cloud in PR #925 but it looks like Bitbucket Server will need a separate solution since the error format differs.

[wide0s]

Is there any update for BitBucket Server? I see it with Bitbucket v8.0.0:

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/atlassian/rest_client.py", line 395, in raise_for_status
    error_msg = "\n".join(j["errorMessages"] + [k + ": " + v for k, v in j["errors"].items()])
KeyError: 'errorMessages'

[gonchik]

Let me merge and polish the next PR #972

[boidolr]

Unfortunately there still is an error with 3.25.0:

atlassian/rest_client.py", line 396, in raise_for_status
    j.get("errorMessages", list()) + [k + ": " + v for k, v in j.get("errors", dict()).items()]
AttributeError: 'list' object has no attribute 'items'

[gonchik]

@boidolr could you post the json from variable -> j = response.json() please?
Maybe better fully wrap an error items.

[boidolr]

@gonchik this happens if I either get or provoke an error, the object looks like this:

{'errors': [{'context': None, 'message': '....', 'exceptionName': 'com.atlassian.bitbucket.pull.InvalidPullRequestTargetException'}]}

Minimal example - the server is running v7.21.0 LTS:

from atlassian import Bitbucket
bb = Bitbucket(url=url, username=user, password=token)
bb.open_pull_request("PROJ", "repo", "PROJ", "repo", "main", "main", "title", "")

[cguldner]

@gonchik The issue is resolved if you replace this line with:

j.get("errorMessages", list()) + [k.get("message", "") for k in j.get("errors", dict())]

[juanmacoo]

@gonchik Have you had some time to look at this? Is there any way we can help?

[gonchik]

fc620ae

[gonchik]

So let me release it