[Confluence] credential fail leads to confusing error

[cybit]

When giving wrong credentials to a Confluence instance I get an AttributeError later on. Which tells me nothing about the reason why it failed.

Example:

confluence = Confluence(
                url=url,
                username=username,
                password=wrong_password,
            )
page_id = confluence.get_page_id(space, page_title)

And I get a TraceBack that ends like this:

page_id = confluence.get_page_id(space, page_title)
   File "lib/python3.7/site-packages/atlassian/confluence.py", line 85, in get_page_id
     return (self.get_page_by_title(space, title) or {}).get('id')
   File "/lib/python3.7/site-packages/atlassian/confluence.py", line 128, in get_page_by_title
     return (self.get(url, params=params) or {}).get('results')[0]
 AttributeError: 'str' object has no attribute 'get'

I would have preferred to get an AuthenticationError or something like that.

[kamilnowak]

Also you have to remember that using API password is not the same password you are passing using UI.
On API password == api key generated in https://id.atlassian.com/manage/api-tokens

[LudovicRousseau]

It is really problematic that an authentication failure is NOT reported as such.
See also #257 for a similar problem.

[dnicholson-fastly]

I'm seeing this trying to get oauth working for Confluence Server as well

[gonchik]

@dnicholson-fastly hm, how we can improve it ?

[gonchik]

Updated docs reduced confusion.

thanks @kblase