Skip to content

Confluence.is_page_content_is_already_updated() should not emit a warning if content is the same #1003

Open
@therealzanfar

Description

@therealzanfar

The purpose of is_page_content_is_already_updated() is to check if the desired page content and the actual page content is different ("Compare content and check is already updated or not"). Based on this, the content being the same isn't a "warning"--it's an expected possibility.

I can understand a warning if update_page() encounters identical content, but with normal logging settings and a completely expected program flow, is_page_content_is_already_updated() behaves as if something wrong has happened.

I suggest changing:

  • atlassian/confluence.py line 1451: change log.warning to log.info
  • atlassian/confluence.py line 1508: insert log.warning("Content of {page_id} is exactly the same".format(page_id=page_id)) below.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions