Changes for Atlas.Query to work with PHP 8.4 #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compwright
reviewed
Aug 26, 2025
src/Select.php
Outdated
| * @method int fetchAffected() | ||
| * @method array|false fetchColumn(int $column = 0) | ||
| * @method array|false fetchGroup(int $style = PDO::FETCH_COLUMN) | ||
| * @method array|false fetchGroup(int $style = 7) // 7 = PDO::FETCH_COLUMN |
There was a problem hiding this comment.
What is the reason for this change? It seems better the way it was.
There was a problem hiding this comment.
phpstan somehow could not detect the constant and was throwing errors. That is the only reason for this change.
There was a problem hiding this comment.
The import may be missing and Atlas\Query\PDO may not exist.
There was a problem hiding this comment.
Well I'll be damned. I completely missed that. Nice catch. Reverted it back
|
@pmjones could we get this going and released? I'm running into deprecation errors in PHP 8.4. Thanks! |
|
Closing this because of scope creep - We can revisit it later if needed. Another PR with the PHP 8.4 changes will follow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed minimum version to PHP 8.1 << Please advise if this is acceptable(removed based on Pdo PR)Added version to composer.json(removed based on Pdo PR)Upgraded phpunit.xml.dist for the new phpunit version(removed based on Pdo PR)QueryTesttoQueryTestCaseto stop phpunit from trying to run tests on it since it is an abstract class (warning on console).Please advise what needs to be changed.
Thanks