Draft
Conversation
luciusmagn
force-pushed
the
lho-config-reloading
branch
from
8f740ff to
0462c59
Compare
Previously, the settings page would show the browser's current runtime state rather than what we just saved in auto-config.lisp. This was confusing as it made it appear that settings weren't being saved. - Add get-configured-value to read values from auto-config - Update all settings controls to check saved values first - Migrate cookie policy and zoom to use define-configuration - Make configure-slot generate define-configuration forms (just in case, I am not sure if it's needed)
luciusmagn
force-pushed
the
lho-config-reloading
branch
from
0462c59 to
bfa1fd3
Compare
jmercouris
force-pushed
the
develop
branch
2 times, most recently
from
05a53a5 to
14e3622
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, the settings page would show the browser's current runtime
state rather than what we just saved in auto-config.lisp.
This was confusing as it made it appear that settings weren't being saved.
(just in case, I am not sure if it's needed)
Checklist:
(asdf:test-system :nyxt/<renderer>))