Skip to content

APP-7132: Fixed FS search criteria used for get_by_qualified_name/guid method to include asset type_name #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

Aryamanz29
Copy link
Member

✨ Description

https://atlanhq.atlassian.net/browse/APP-7132


🧩 Type of change

Select all that apply:

  • 🚀 New feature (non-breaking change that adds functionality)
  • 🐛 Bug fix (non-breaking change that fixes an issue) — please include tests! Refer testing-toolkit 🧪
  • 🔄 Refactor (code change that neither fixes a bug nor adds a feature)
  • 🧹 Maintenance (chores, cleanup, minor improvements)
  • 💥 Breaking change (fix or feature that may break existing functionality)
  • 📦 Dependency upgrade/downgrade
  • 📚 Documentation updates

✅ How has this been tested? (e.g. screenshots, logs, workflow links)

Describe how the change was tested. Include:

  • Steps to reproduce
  • Any relevant screenshots, logs, or links to successful workflow runs
  • Details on environment/setup if applicable

📋 Checklist

  • My code follows the project’s style guidelines
  • I’ve performed a self-review of my code
  • I’ve added comments in tricky or complex areas
  • I’ve updated the documentation as needed
  • There are no new warnings from my changes
  • I’ve added tests to cover my changes
  • All new and existing tests pass locally

@Aryamanz29 Aryamanz29 self-assigned this Jun 16, 2025
@Aryamanz29 Aryamanz29 requested review from Copilot and vaibhavatlan and removed request for vaibhavatlan June 16, 2025 09:11
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with the FS search criteria used in the get_by_qualified_name and get_by_guid methods by adding an additional filter for the asset type name.

  • Updated the search query in get_by_qualified_name to include a condition on Asset.TYPE_NAME.
  • Updated the search query in get_by_guid similarly for asset type filtering.
Comments suppressed due to low confidence (2)

pyatlan/client/asset.py:445

  • Verify that asset_type's name property reliably represents the intended asset type for filtering to avoid any runtime mismatches.
.where(Asset.TYPE_NAME.eq(asset_type.__name__))

pyatlan/client/asset.py:519

  • Ensure that the asset_type parameter consistently provides a valid name value so that the added filtering works as expected.
.where(Asset.TYPE_NAME.eq(asset_type.__name__))

@Aryamanz29 Aryamanz29 merged commit 2096f1e into main Jun 16, 2025
51 of 52 checks passed
@Aryamanz29 Aryamanz29 deleted the APP-7132 branch June 16, 2025 09:45
@Aryamanz29 Aryamanz29 added the bugfix Bug fix pull request label Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fix pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant