Add get_asset_history tool #145
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hk669
reviewed
Sep 18, 2025
Comment on lines
+217
to
+218
| "count": len(entity_audits), | ||
| "totalCount": response.total_count, |
There was a problem hiding this comment.
what is the difference between count and totalCount?
There was a problem hiding this comment.
Count is the number of audit entries that are now being sent by the MCP, which should be actually equal to the number of entries requested by the user in the request. And total_count is the total number of entries that can be obtained from Atlas.
modelcontextprotocol/server.py
Outdated
| size (int): Number of history entries to return. Defaults to 10. | ||
| sort_order (str): Sort order for results. "ASC" for oldest first, "DESC" for newest first. | ||
| Defaults to "DESC". | ||
| include_attributes (List[Union[str, AtlanField]], optional): List of additional attributes to include in results. |
There was a problem hiding this comment.
agents doesnt understand AtlanField in the context.
There was a problem hiding this comment.
I will update.
modelcontextprotocol/tools/assets.py
Outdated
| type_name: Optional[str] = None, | ||
| size: int = 10, | ||
| sort_order: str = "DESC", | ||
| include_attributes: Optional[List[Union[str, AtlanField]]] = None, |
There was a problem hiding this comment.
if it supports AtlanField, AuditRequest should support these attributes right? whats the reason for snake to camelCase? check if it supports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new tool get_asset_history for the following usecases
Tested for prompts like:
"when was the description updated and who updated it for x asset?"
"who was the owner of this x asset on y date"
"what was the description of this asset before it was last updated?"
"who changes the description from x to y for z asset?"