This repository was archived by the owner on Jan 6, 2025. It is now read-only.
Add rename tab functionality #62
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #41 Add functionality to rename tabs. * Add `renameTab` function in `packages/terminal/app/page.tsx` to handle renaming tabs. * Update `Page` component to include a button for renaming tabs and display the renamed tab names. * Add `tabName` prop to `Tab` component in `packages/terminal/components/Tab/index.tsx` and update it to display the `tabName` instead of `tabId`. * Add a button for renaming tabs in `TitleBar` component in `packages/terminal/components/TitleBar/index.tsx`. * Add `renameTab` function in `ConfigModule` in `packages/app/src/nativeBridge/modules/configModule.ts` to handle renaming tabs. * Add `renameTab` function in `ApplicationModule` in `packages/app/src/nativeBridge/modules/applicationModule.ts` to handle renaming tabs. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/atinylittleshell/TerminalOne/issues/41?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #41
Add functionality to rename tabs.
renameTabfunction inpackages/terminal/app/page.tsxto handle renaming tabs.Pagecomponent to include a button for renaming tabs and display the renamed tab names.tabNameprop toTabcomponent inpackages/terminal/components/Tab/index.tsxand update it to display thetabNameinstead oftabId.TitleBarcomponent inpackages/terminal/components/TitleBar/index.tsx.renameTabfunction inConfigModuleinpackages/app/src/nativeBridge/modules/configModule.tsto handle renaming tabs.renameTabfunction inApplicationModuleinpackages/app/src/nativeBridge/modules/applicationModule.tsto handle renaming tabs.For more details, open the Copilot Workspace session.